AliveDevil/pdns-dhcp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Review

Browse source
This commit is contained in:
Jöran Malek 2024-01-01 23:10:14 +01:00
parent 71d8923f5c
commit 1e42791584
1 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/pdns-dhcp/Dns/DnsRepository.cs
View file

@ -14,6 +14,7 @@ public class DnsRepository
private readonly ReaderWriterLockSlim _recordLock = new(); private readonly ReaderWriterLockSlim _recordLock = new();
private readonly List<DnsRecord> _records = []; private readonly List<DnsRecord> _records = [];
private readonly SemaphoreSlim _syncLock = new(1, 1);
public List<DnsRecord> Find(Predicate<DnsRecord> query) public List<DnsRecord> Find(Predicate<DnsRecord> query)
{ {
@ -40,20 +41,27 @@ public class DnsRepository
public async ValueTask Record(DnsRecord record, CancellationToken cancellationToken = default) public async ValueTask Record(DnsRecord record, CancellationToken cancellationToken = default)
{ {
// just lock that thing. bool entered = false;
using (await _recordLock.AcquireLockAsync(cancellationToken).ConfigureAwait(false)) try
{ {
entered = await _syncLock.WaitAsync(Timeout.Infinite, cancellationToken).ConfigureAwait(continueOnCapturedContext: false);
RecordContinuation(record); RecordContinuation(record);
} }
finally
{
if (entered)
{
_syncLock.Release();
}
}
void RecordContinuation(DnsRecord record) void RecordContinuation(DnsRecord record)
{ {
var search = Matches(record); var search = Matches(record);
bool lockEntered = false; bool entered = false;
try try
{ {
lockEntered = _recordLock.TryEnterWriteLock(Timeout.Infinite); entered = _recordLock.TryEnterWriteLock(Timeout.Infinite);
if (search.First is { } node) if (search.First is { } node)
{ {
@ -79,7 +87,7 @@ public class DnsRepository
} }
finally finally
{ {
if (lockEntered) if (entered)
{ {
_recordLock.ExitWriteLock(); _recordLock.ExitWriteLock();
} }